> On Feb. 8, 2016, 8:04 p.m., Avinash sridharan wrote: > > src/slave/slave.cpp, line 3178 > > <https://reviews.apache.org/r/43258/diff/3/?file=1236975#file1236975line3178> > > > > Should we be destroying the container on failure of the `Future`? This > > is what we are doing in `_statusupdate`
The `LOG(WARNING)` in `_statusUpdate` suggests that its an implicit assumption in `_statusupdate` that it will be called from `containerizer->update`. Since the current changes are maintaining that assumption, we can drop this defect. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/#review118280 ----------------------------------------------------------- On Feb. 9, 2016, 4:16 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43258/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2016, 4:16 a.m.) > > > Review request for mesos, Jie Yu and Kapil Arya. > > > Bugs: MESOS-4490 > https://issues.apache.org/jira/browse/MESOS-4490 > > > Repository: mesos > > > Description > ------- > > Modified agent to get container status from containerizer. > > > Diffs > ----- > > src/slave/slave.hpp a3830ff460a6f6c5661fb8a0172fae303b245889 > src/slave/slave.cpp 9dda3a2c4dc4c355488d34dc8d0606330a756f2a > > Diff: https://reviews.apache.org/r/43258/diff/ > > > Testing > ------- > > make and make check > > > Thanks, > > Avinash sridharan > >
