-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43258/#review118478
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp (line 3098)
<https://reviews.apache.org/r/43258/#comment179715>

    Please add a second NOTE here saying that we don't set the ContainerStatus 
(including the IP address in NetworkInfo) because the container no longer 
exists. We cannot use the slave IP because it's unclear what network isolation 
is used.



src/slave/slave.cpp (line 3153)
<https://reviews.apache.org/r/43258/#comment179718>

    s/containerStatus/future/



src/slave/slave.cpp (line 3155)
<https://reviews.apache.org/r/43258/#comment179716>

    No need for this. Please use `StatusUpdate update` as the parameter so that 
you can directly modify it



src/slave/slave.cpp (line 3157)
<https://reviews.apache.org/r/43258/#comment179719>

    s/container/containerStatus/



src/slave/slave.cpp (lines 3170 - 3183)
<https://reviews.apache.org/r/43258/#comment179720>

    I think we should only do this if 'future' is Ready. Otherwise, we cannot 
tell if we should fill IP or not because a network isolator might be used and 
it advertised a different IP.



src/slave/slave.cpp (line 3188)
<https://reviews.apache.org/r/43258/#comment179717>

    Kill this line


- Jie Yu


On Feb. 9, 2016, 10:08 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43258/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 10:08 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Kapil Arya.
> 
> 
> Bugs: MESOS-4490
>     https://issues.apache.org/jira/browse/MESOS-4490
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modified agent to get container status from containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp a3830ff460a6f6c5661fb8a0172fae303b245889 
>   src/slave/slave.cpp 9dda3a2c4dc4c355488d34dc8d0606330a756f2a 
>   src/tests/master_tests.cpp 0357b1c259472213181a65e5adbe6d5caa1698ad 
>   src/tests/reconciliation_tests.cpp 1cbc3230d003a84277b91da6470828ebf73ef897 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
>   src/tests/status_update_manager_tests.cpp 
> 7bedd499a241a61938069381e0d4fafa4b8f96db 
> 
> Diff: https://reviews.apache.org/r/43258/diff/
> 
> 
> Testing
> -------
> 
> make and make check
> 
> 
> Also ran sudo tests . All tests passed except for these root tests:
> DockerContainerizerTest.ROOT_DOCKER_Launch_Executor (this is failing on the 
> master as well, and seems flaky ?)
> CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_Listen  (Since swap was 
> enabled on the system)
> CgroupsAnyHierarchyMemoryPressureTest.ROOT_IncreaseRSS (Since swap was 
> enabled on the system)
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to