----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43138/#review118431 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (lines 524 - 531) <https://reviews.apache.org/r/43138/#comment179640> How about we document the assumptions (or invariants that are assumed here). The current note suggests a bug in the existing code. - Ben Mahler On Feb. 3, 2016, 2:52 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43138/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 2:52 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 1a07d69016407e5aad2209586da37fecbcddb765 > > Diff: https://reviews.apache.org/r/43138/diff/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
