> On Feb. 9, 2016, 10:51 p.m., Kevin Klues wrote: > > I don't mind these changes. I had catches similar to these in eralier > > versions of this script (https://reviews.apache.org/r/43220/diff/2/), but > > reviews pointed to removing them in favor of printing the "ugly" stack > > traces.
The first behavior (printing an exception on exit if `current_subprocess` happens to be `None`) is a bug, in my opinion. The second behavior is more debatable, I agree. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43384/#review118489 ----------------------------------------------------------- On Feb. 9, 2016, 10:43 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43384/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2016, 10:43 p.m.) > > > Review request for mesos, Ben Mahler and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Two problems: > > (1) If the script exited when `current_subprocess` is None, it > would print an ugly exception stack trace. > > (2) If starting the Mesos master or agent failed, it would print > an ugly exception stack trace. > > > Diffs > ----- > > support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 > > Diff: https://reviews.apache.org/r/43384/diff/ > > > Testing > ------- > > Ran the script in error and non-error cases with the changes applied. > > > Thanks, > > Neil Conway > >
