-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43388/#review118519
-----------------------------------------------------------



It's unfortunate that the docs don't currently maintain a single convention for 
line-wrapping, but they are locally consistent within each file. I would 
recommend picking either wrapping at 80 characters or not at all, and keep it 
consistent throughout this entire file.


docs/authentication.md (line 26)
<https://reviews.apache.org/r/43388/#comment179789>

    Perhaps a bit misleading to call the secret an "arbitrary string" here. 
Maybe something like "the secret is used to verify that identity."?



docs/authentication.md (line 43)
<https://reviews.apache.org/r/43388/#comment179793>

    Nit: perhaps true/false should be monospace formatted here, rather than 
single-quoted?



docs/authentication.md (line 67)
<https://reviews.apache.org/r/43388/#comment179790>

    Not sure if you want to add it in this patch, but it would be useful to 
also have an example of credentials in JSON format.



docs/authentication.md (line 72)
<https://reviews.apache.org/r/43388/#comment179791>

    Monospace formatting for the filename, here and below?


- Greg Mann


On Feb. 10, 2016, 12:10 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43388/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Revised authentication documentation.
> 
> 
> Diffs
> -----
> 
>   docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 
> 
> Diff: https://reviews.apache.org/r/43388/diff/
> 
> 
> Testing
> -------
> 
> Previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to