----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43388/#review118531 -----------------------------------------------------------
Fix it, then Ship it! Looks good, but I'd include a mention of FrameworkInfo.principal for use with authorization. docs/authentication.md (line 47) <https://reviews.apache.org/r/43388/#comment179798> We may be deprecating the plaintext format soon docs/authentication.md (lines 61 - 63) <https://reviews.apache.org/r/43388/#comment179796> To enable authorization based on the authenticated principal, the framework developer should also copy the Credential.principal into FrameworkInfo.principal when registering. docs/authentication.md (line 86) <https://reviews.apache.org/r/43388/#comment179801> Step 6.? - Adam B On Feb. 9, 2016, 4:10 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43388/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2016, 4:10 p.m.) > > > Review request for mesos, Adam B, Greg Mann, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Revised authentication documentation. > > > Diffs > ----- > > docs/authentication.md b40b09eaceddc8e5498b54b3e8ef7a5dbd7b9dc2 > > Diff: https://reviews.apache.org/r/43388/diff/ > > > Testing > ------- > > Previewed in site-docker. > > > Thanks, > > Neil Conway > >
