> On Feb. 10, 2016, 3:39 a.m., Guangya Liu wrote:
> > src/tests/fetcher_cache_tests.cpp, line 424
> > <https://reviews.apache.org/r/43367/diff/2/?file=1239195#file1239195line424>
> >
> >     Can you introduce a new member variable named as `master flags` and get 
> > the allocation interval from `flags.allocation_interval`?

How about use `DEFAULT_ALLOCATION_INTERVAL` here directly? So that we could 
move above
```
  masterFlags = CreateMasterFlags();
  Try<PID<Master>> master = StartMaster(masterFlags);
```
as well.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review118563
-----------------------------------------------------------


On Feb. 10, 2016, 1:42 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4618
>     https://issues.apache.org/jira/browse/MESOS-4618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up FetcherCache test cases by advance allocation_interval.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> -------
> 
> Before this patch:
> ```
> [       OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [       OK ] FetcherCacheTest.LocalCached (1728 ms)
> [       OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [       OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [       OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [       OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [       OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
> 
> After this patch:
> ```
> [       OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [       OK ] FetcherCacheTest.LocalCached (1693 ms)
> [       OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [       OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [       OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [       OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [       OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [       OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to