> On 二月 10, 2016, 11:32 a.m., haosdent huang wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2409 > > <https://reviews.apache.org/r/42342/diff/3/?file=1239306#file1239306line2409> > > > > should we settle before `advance`
I think it should be OK as long as the `settle` is before `allocations.get()`, because I need to make sure the `recoverResources` is finished before get `allocations`. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42342/#review118627 ----------------------------------------------------------- On 二月 10, 2016, 5:09 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42342/ > ----------------------------------------------------------- > > (Updated 二月 10, 2016, 5:09 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-4387 > https://issues.apache.org/jira/browse/MESOS-4387 > > > Repository: mesos > > > Description > ------- > > Added a new test cases for revive offer. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 990f3723d52dfeaa19d5eb0603c0fc7eb2b362c7 > > Diff: https://reviews.apache.org/r/42342/diff/ > > > Testing > ------- > > make > make check > GLOG_v=2 ./bin/mesos-tests.sh > --gtest_filter="HierarchicalAllocatorTest.ReviveOffers" --verbose > > > Thanks, > > Guangya Liu > >
