-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43488/#review119284
-----------------------------------------------------------




include/mesos/mesos.proto (line 261)
<https://reviews.apache.org/r/43488/#comment180597>

    Can you please also add some comments here for the usage of 
`TASK_KILLING_STATE`



include/mesos/v1/mesos.proto (line 261)
<https://reviews.apache.org/r/43488/#comment180598>

    ditto



src/tests/master_tests.cpp (lines 3063 - 3077)
<https://reviews.apache.org/r/43488/#comment180601>

    It will be difficult to update this if adding another new framework 
capability, can you please use a `for` loop to handle this?
    
    Also I think that the {} is not needed here.



src/tests/master_tests.cpp (lines 3067 - 3068)
<https://reviews.apache.org/r/43488/#comment180603>

    4 spaces



src/tests/master_tests.cpp (lines 3075 - 3076)
<https://reviews.apache.org/r/43488/#comment180604>

    4 spaces


- Guangya Liu


On 二月 16, 2016, 8:25 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43488/
> -----------------------------------------------------------
> 
> (Updated 二月 16, 2016, 8:25 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Qian Zhang.
> 
> 
> Bugs: MESOS-4547
>     https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding framework capability for TASK_KILLING.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 
>   include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 
>   src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
> 
> Diff: https://reviews.apache.org/r/43488/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Reply via email to