-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43041/#review119279
-----------------------------------------------------------




src/master/master.cpp (line 5283)
<https://reviews.apache.org/r/43041/#comment180596>

    s/Create add add/Create and add/
    
    Maybe "Create offer with regular resources only."



src/master/master.cpp (line 5284)
<https://reviews.apache.org/r/43041/#comment180592>

    Use `Resources::nonRevocable()`
    
    Maybe use `Try<Offer> createOffer(...)` is better; so we can check the 
parameters in `createOffer()`.



src/master/master.cpp (line 5285)
<https://reviews.apache.org/r/43041/#comment180600>

    Remove empty line.



src/master/master.cpp (line 5292)
<https://reviews.apache.org/r/43041/#comment180599>

    ditto



src/tests/oversubscription_tests.cpp (line 588)
<https://reviews.apache.org/r/43041/#comment180595>

    `EXPECT_EQ(offer1.slaveID(), offer2.slaveID())`


- Klaus Ma


On Feb. 16, 2016, 4:52 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43041/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 4:52 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, 
> Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2646
>     https://issues.apache.org/jira/browse/MESOS-2646
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update Master to send revocable resources in separate offers.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
>   src/tests/oversubscription_tests.cpp 
> d4ae81972fd218c58a413d1968a4e9acbee52fd3 
> 
> Diff: https://reviews.apache.org/r/43041/diff/
> 
> 
> Testing
> -------
> 
> Make && Make check
>  
> Test: https://reviews.apache.org/r/43593/
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Reply via email to