> On Feb. 16, 2016, 10:08 a.m., Klaus Ma wrote: > > src/master/master.cpp, line 5285 > > <https://reviews.apache.org/r/43041/diff/4/?file=1241830#file1241830line5285> > > > > Use `Resources::nonRevocable()` > > > > Maybe use `Try<Offer> createOffer(...)` is better; so we can check the > > parameters in `createOffer()`.
Use 'Try<offer>' except some error happened in createOffer function, in this patch use 'Offer' is enough due to no any error happened. - Yongqiao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43041/#review119279 ----------------------------------------------------------- On Feb. 16, 2016, 8:52 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43041/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 8:52 a.m.) > > > Review request for mesos, Guangya Liu, Klaus Ma, Niklas Nielsen, Qian Zhang, > Jian Qiu, and Vinod Kone. > > > Bugs: MESOS-2646 > https://issues.apache.org/jira/browse/MESOS-2646 > > > Repository: mesos > > > Description > ------- > > Update Master to send revocable resources in separate offers. > > > Diffs > ----- > > src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572 > src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 > src/tests/oversubscription_tests.cpp > d4ae81972fd218c58a413d1968a4e9acbee52fd3 > > Diff: https://reviews.apache.org/r/43041/diff/ > > > Testing > ------- > > Make && Make check > > Test: https://reviews.apache.org/r/43593/ > > > Thanks, > > Yongqiao Wang > >
