----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/#review119507 -----------------------------------------------------------
In general, I prefer scripts with a bunch of helper functions and a compact main() that steps through each of them. I'm not sure what the general concensus for the Mesos code base is, but I generally find this easier to walk through. Example: support/generate-endpoint-help.py support/push-reviews.py (line 19) <https://reviews.apache.org/r/43552/#comment180861> need to import sys support/push-reviews.py (lines 27 - 30) <https://reviews.apache.org/r/43552/#comment180868> Do we have guidelines for indentation here? When writing the support/generate-endpoints-help.py script, bmahler suggested something different than what you have here. support/push-reviews.py (lines 32 - 39) <https://reviews.apache.org/r/43552/#comment180865> If the tracking branch is reauired to be of the form `remote/branch` (as mentioned in a later comment), what do we need the `remote` flag for? support/push-reviews.py (line 52) <https://reviews.apache.org/r/43552/#comment180864> We need some sort of way to enforce that the tracking branch is always of the form `remote/branch`. Otherwise, if we run e.g. ``` $ klueska@c99:~/projects/mesos$ support/push-reviews.py -t master ``` remote gets set to `master` here, which obviously breaks things later on. support/push-reviews.py (lines 108 - 112) <https://reviews.apache.org/r/43552/#comment180867> As we close the review, we should also post a comment to reviewboard with the commit message we actually pushed to master. You can use the --description flag: https://www.reviewboard.org/docs/rbtools/dev/rbt/commands/close/ - Kevin Klues On Feb. 17, 2016, 12:31 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43552/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2016, 12:31 a.m.) > > > Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park. > > > Bugs: MESOS-3929 > https://issues.apache.org/jira/browse/MESOS-3929 > > > Repository: mesos > > > Description > ------- > > This script allows committers to push locally applied review chain to the ASF > git repo and mark the reviews as submitted. > > > Diffs > ----- > > support/push-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/43552/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Vinod Kone > >
