----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/#review120452 -----------------------------------------------------------
support/push-reviews.py (lines 123 - 125) <https://reviews.apache.org/r/43552/#comment181907> Ah, I see it now. There is another call to `if not options['dry_run']` inside the `close_reviews()` call which protects it from actually closing it on rb. Seems like this could be consolidated somehow, since it's a little confusing at first glance, but may not be worth the effort. - Kevin Klues On Feb. 22, 2016, 4:52 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43552/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 4:52 a.m.) > > > Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park. > > > Bugs: MESOS-3929 > https://issues.apache.org/jira/browse/MESOS-3929 > > > Repository: mesos > > > Description > ------- > > This script allows committers to push locally applied review chain to the ASF > git repo and mark the reviews as submitted. > > > Diffs > ----- > > support/push-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/43552/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Vinod Kone > >
