----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review119636 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/docker.cpp (line 1746) <https://reviews.apache.org/r/43015/#comment180986> Fix the indentation here. src/slave/containerizer/docker.cpp (lines 1856 - 1861) <https://reviews.apache.org/r/43015/#comment180988> Can you move that to `___destroy`? src/tests/containerizer/docker_containerizer_tests.cpp (line 1447) <https://reviews.apache.org/r/43015/#comment181007> Kill this line here. - Jie Yu On Feb. 18, 2016, 6:16 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43015/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 6:16 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-3413 > https://issues.apache.org/jira/browse/MESOS-3413 > > > Repository: mesos > > > Description > ------- > > Fixed persistent volumes with docker tasks. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 > src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc > src/tests/containerizer/docker_containerizer_tests.cpp > 645bdcf095145097d8b8c65d592c787417883145 > > Diff: https://reviews.apache.org/r/43015/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
