----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review119501 -----------------------------------------------------------
src/slave/containerizer/docker.cpp (lines 1785 - 1790) <https://reviews.apache.org/r/43015/#comment180857> the destroy can be initiated by the slave, right? it's possible that `docker->stop` above failed (meaning that the container is still running). You should not remove mounts in that case, isn't it? - Jie Yu On Feb. 16, 2016, 3:33 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43015/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 3:33 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-3413 > https://issues.apache.org/jira/browse/MESOS-3413 > > > Repository: mesos > > > Description > ------- > > Fixed persistent volumes with docker tasks. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 > src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc > src/tests/containerizer/docker_containerizer_tests.cpp > 645bdcf095145097d8b8c65d592c787417883145 > > Diff: https://reviews.apache.org/r/43015/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
