-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43328/#review119721
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43715, 43328]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 18, 2016, 4:48 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43328/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Bugs: MESOS-4588
>     https://issues.apache.org/jira/browse/MESOS-4588
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Title for documentation webpages.
> 
> 
> Diffs
> -----
> 
>   docs/allocation-module.md 3bbb9045dea2c0e50c4791cc3e220cfe383e0b7b 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   docs/architecture.md d1b3c0e7ffab1b9e70fc51282a46cf97b7718a48 
>   docs/attributes-resources.md 818da8ab0c672144b02f526b2b805cf0505d2c7e 
>   docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
>   docs/authorization.md bbb4f2adc9348cb1686e6af78f5604d8cf7651ab 
>   docs/c++-style-guide.md 5e2d88d5a7ae06191346bf672f58dbe27b2bccee 
>   docs/clang-format.md 5e720e016ae2635c6a3e1825c0a7fc36f1ef07b7 
>   docs/committer-candidate-checklist.md 
> fd55a398c836a30ba80203a64ba10fefe2cb9108 
>   docs/committers.md 94ee9a6553ad5cd894db6f71825f46a7a3239eb8 
>   docs/committing.md eabc0aad9c4fb96586fd1ae3bd2935e1a1a9c3a7 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   docs/containerizer-internals.md 20bf2d16d4f06994ee766a0c15f3528513751efe 
>   docs/containerizer.md cd23cf9c006b862e6e2cf4e215706eff03cd07f8 
>   docs/deploy-scripts.md 87f8eb6254dbf00dc537a180b8d3e0084165d17c 
>   docs/docker-containerizer.md 89dfa0ba4b8f7b9761ce48340b30daa5a30bd8cc 
>   docs/documentation-guide.md b7e861468e8abe1b8e83c115d353e78e601fb41f 
>   docs/doxygen-style-guide.md 1bd3b3d373af4ab39df1ab8b1ed9c78dc3bfc721 
>   docs/effective-code-reviewing.md 5a633bc324290bc1f57884bab550ee9f246f9d0f 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/executor-http-api.md fd80005002694bcc72abd04ceea35a2d00814401 
>   docs/external-containerizer.md 8a16e5a75e374fc2848e57cb108dc5b4df7e5be1 
>   docs/fetcher-cache-internals.md 1ccb1c2cbb0a80771f79e98c0bdcc8ee8464ea30 
>   docs/fetcher.md 30f9d0f7f622db7ac960c5bf255319c2553b94ee 
>   docs/framework-rate-limiting.md af33c5e9ed7c5519dc58c7c5657f3c999de3dd1f 
>   docs/frameworks.md e3d50f608ca1e5752f65c411eb09483074146562 
>   docs/getting-started.md dd7b1f063367568de2ff2b2a371023b71e1923de 
>   docs/high-availability-framework-guide.md 
> f21f95f24c0e9f3c4376b64e6a5776aafec39172 
>   docs/high-availability.md 3e9802bd3a2a6f75fff3aea3cfb319adce3271cf 
>   docs/home.md 982ad28d392570b40b83e9e85d21583b88ff755e 
>   docs/logging.md 50a95ba5fedcb5b803e183bea8243e2e7750aa3e 
>   docs/maintenance.md e6bfe0f655581a6a72de4579bd7e5753625c0e51 
>   docs/markdown-style-guide.md 2f400d8ed61d26d5978907baec7761a328f770ad 
>   docs/mesos-containerizer.md 87f145cd957dcb8fd3188c866212b417f0ab6296 
>   docs/mesos-provisioner.md 3597cfc1d484a25f885ff95ab6ce05d615fc2c74 
>   docs/modules.md 8e0249d9829a06b3245fc193f0ee383956d33375 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   docs/multiple-disk.md ab2e7e84398fda4abdae1bdd5daebe78b1e075b3 
>   docs/network-monitoring.md 57b859e9292dc22613e235710312d1a33f58e0c0 
>   docs/networking-for-mesos-managed-containers.md 
> f2fbea54cc3a7f1727c53629c86feb25d7f5fd68 
>   docs/newbie-guide.md f6e61210ed834d245fd4922c1dbbf1e7d05ff64e 
>   docs/operational-guide.md 4680ee3397d081acd6f82499703de4456e7ca4f4 
>   docs/oversubscription.md 0b1c20bf9bae9c179d82f5f611638faf91f91431 
>   docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de 
>   docs/powered-by-mesos.md 6e113ee6923d88a4d8188fa55c6c23fd8aaa35b4 
>   docs/presentations.md d29bbaf5677b68ee1f47308047a1c56869284710 
>   docs/quota.md d4233be0f39e05c1c326680dbddae1ec601eef4f 
>   docs/reconciliation.md ea11905720a3cd60e88b18e64e5b882f5e250166 
>   docs/release-guide.md a0d27cbafeb5311d2c704dcb632b4de179ba994c 
>   docs/reporting-a-bug.md b980159a7988ba952d908034317b39007c12cf2d 
>   docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6 
>   docs/roadmap.md 1f68ba0f63325c2f4cf5718c7afc67d39622ae9c 
>   docs/roles.md 84e5b7eaa4cf5cd3e7ebd6151928210be93d1d56 
>   docs/sandbox.md 276e1126f495e7af15afd4f4ad8c63beb40db739 
>   docs/scheduler-http-api.md 42e2c514ad027b9007aadda46eabd5c530f89eaa 
>   docs/slave-recovery.md acf36b9693972641f38a96e8d6b682e02b6cdbb3 
>   docs/ssl.md be30b696102b2a5b16d88bc10894f13e67d27f4b 
>   docs/submitting-a-patch.md 50361a9c9c4a246d6ee939f057eeabf4c88eb297 
>   docs/testing-patterns.md cc150d6204992b551fe820d5aab54d6a6f60597d 
>   docs/tools.md 6234e38c017d8284b2d1a31de63110598c3c60c7 
>   docs/upgrades.md 4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 
>   docs/versioning.md cc31fd53d5bd33168fed0a7c3408616f7c1e9858 
> 
> Diff: https://reviews.apache.org/r/43328/diff/
> 
> 
> Testing
> -------
> 
> Tested with rake dev to see if the effects are coming in the live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Reply via email to