-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review119797
-----------------------------------------------------------



LGTM, some minor comments around avoiding redundant use of `Clock` functions 
that can be avoided.


src/tests/hook_tests.cpp (line 390)
<https://reviews.apache.org/r/42241/#comment181146>

    hmm ... Can't we just do:
    
    ```
    Clock::pause();
    Clock::advance(...);
    Clock::settle();
    ```



src/tests/hook_tests.cpp (line 392)
<https://reviews.apache.org/r/42241/#comment181148>

    Missing period at the end.



src/tests/hook_tests.cpp (line 396)
<https://reviews.apache.org/r/42241/#comment181147>

    Is there a need to explicitly invoke `Clock::resume()` here? If not, kill 
it.


- Anand Mazumdar


On Jan. 18, 2016, 4:03 p.m., Jian Qiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 4:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
>     https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -----
> 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> -------
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Reply via email to