> On Feb. 19, 2016, 2:50 a.m., Anand Mazumdar wrote:
> > src/tests/hook_tests.cpp, line 390
> > <https://reviews.apache.org/r/42241/diff/3/?file=1200496#file1200496line390>
> >
> >     hmm ... Can't we just do:
> >     
> >     ```
> >     Clock::pause();
> >     Clock::advance(...);
> >     Clock::settle();
> >     ```
> 
> Jian Qiu wrote:
>     Thanks for reviewing! This settle() is necessary to trigger the 
> shutdownExecutor timer.

Ahh, I see. It's not immediatly obvious to to why we need the first 
`Clock::settle`. As a suggestion, can we add a comment like this:

```
Clock::settle(); // Wait for `Slave::shutdownExecutor` to complete.
```


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review119797
-----------------------------------------------------------


On Feb. 19, 2016, 3:29 a.m., Jian Qiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 3:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
> 
> 
> Bugs: MESOS-4174
>     https://issues.apache.org/jira/browse/MESOS-4174
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
> 
> 
> Diffs
> -----
> 
>   src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 
> 
> Diff: https://reviews.apache.org/r/42241/diff/
> 
> 
> Testing
> -------
> 
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
> 
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Reply via email to