> On Feb. 19, 2016, 12:07 a.m., Shuai Lin wrote:
> > src/slave/flags.cpp, line 693
> > <https://reviews.apache.org/r/43701/diff/1/?file=1253452#file1253452line693>
> >
> >     One space before `\n`, otherwise the word would be mixed with the first 
> > word of the next line.

I do not think we will have such issue, you can take a look at the all other 
existing flags, they all do the same way. And here is the output when I run 
"./src/mesos-slave --help":
# ./src/mesos-slave --help
Usage: lt-mesos-slave [options]
...
--[no-]http_command_executor                      Enable mesos containerizer to 
use HTTP command executor which uses
                                                  executor HTTP API to interact 
with Mesos agent. If false, the old
                                                  command executor which uses 
executor driver API will be used.
                                                  default: false)
...

I think the output is desired.


> On Feb. 19, 2016, 12:07 a.m., Shuai Lin wrote:
> > src/slave/slave.cpp, line 3709
> > <https://reviews.apache.org/r/43701/diff/1/?file=1253453#file1253453line3709>
> >
> >     Instead of repeating the `if (flags.http_command_executor)...` logic 
> > multiple times, I would prefer use a temp variable to store either 
> > `mesos-executor` or `mesos-http-executor`.

I am not sure if I get your point correctly, can you please clarify how to use 
the temp var? BTW, such logic is just repeated twice in 
`Slave::getExecutorInfo`, it seems not a big deal to me :-)


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43701/#review119623
-----------------------------------------------------------


On Feb. 18, 2016, 9:09 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43701/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 9:09 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a command executor based on the new V1 API.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
>   src/Makefile.am 54ebe91643a17017c00cdbd5dfc8ce1a021579d5 
>   src/launcher/http_executor.cpp PRE-CREATION 
>   src/slave/flags.hpp bd52b4f9816b271a9d2728ae6915f8e24b74d716 
>   src/slave/flags.cpp d4b4e5201bb3a7e8edd0ab2481328fc91cd8f974 
>   src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 
> 
> Diff: https://reviews.apache.org/r/43701/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to