> On Feb. 18, 2016, 4:07 p.m., Shuai Lin wrote: > > src/slave/slave.cpp, line 3709 > > <https://reviews.apache.org/r/43701/diff/1/?file=1253453#file1253453line3709> > > > > Instead of repeating the `if (flags.http_command_executor)...` logic > > multiple times, I would prefer use a temp variable to store either > > `mesos-executor` or `mesos-http-executor`. > > Qian Zhang wrote: > I am not sure if I get your point correctly, can you please clarify how > to use the temp var? BTW, such logic is just repeated twice in > `Slave::getExecutorInfo`, it seems not a big deal to me :-)
Fair enough. - Shuai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43701/#review119623 ----------------------------------------------------------- On Feb. 20, 2016, 1:44 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43701/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2016, 1:44 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-3558 > https://issues.apache.org/jira/browse/MESOS-3558 > > > Repository: mesos > > > Description > ------- > > Added a command executor based on the new V1 API. > > > Diffs > ----- > > docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23 > include/mesos/v1/mesos.proto e4224afe2245d649afa1a6c97bae26c215e6fada > src/Makefile.am 27aec37524aa33211e0ca4594e127ebb4279e9b0 > src/launcher/http_executor.cpp PRE-CREATION > src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 > src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a > src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 > > Diff: https://reviews.apache.org/r/43701/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
