-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43782/
-----------------------------------------------------------
Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-4591
https://issues.apache.org/jira/browse/MESOS-4591
Repository: mesos
Description
-------
Changed object of `CreateVolume` ACL to `roles`.
This solves a problem in which any principal could create volumes for any role
using the '/create-volumes' operator endpoint.
Diffs
-----
include/mesos/authorizer/authorizer.proto
226441f8cbd6d0828bf1636cc08c21ffcc75e6a7
src/authorizer/local/authorizer.cpp 9557bbdf68ff182c4538bbf70cee576d717abc05
src/master/master.cpp e5aaf67e63996700b2cdcdd04055ad5b04bfb085
src/tests/authorization_tests.cpp 9d046e8d53cbb6c065a23ca3f7832021ec7faadc
src/tests/persistent_volume_endpoints_tests.cpp
6069ca1e9ed278459c5182e438417e95955b1924
src/tests/persistent_volume_tests.cpp
e169e1b141a38dc389eefd42c11a078c413123d5
Diff: https://reviews.apache.org/r/43782/diff/
Testing
-------
Persistent volume tests and operation validation tests were altered to
accomodate the new ACL object, and some new principal/role combinations were
added to `AuthorizationTest.CreateVolume`.
Ran `configure && make check` and `configure --enable-libevent --enable-ssl &&
make check` on OSX; all tests passed.
Thanks,
Greg Mann
