----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43826/#review120126 -----------------------------------------------------------
Fix it, then Ship it! LGTM. I am still convinced that using scope deliberately is a core tool when programming in C++, and starting with a motivating example from Java seems weird, but what you wrote here reads well and makes a lot of sense. site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 49) <https://reviews.apache.org/r/43826/#comment181507> s/^w/W/ site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 97) <https://reviews.apache.org/r/43826/#comment181505> s/constrast/contrast/ site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (lines 302 - 303) <https://reviews.apache.org/r/43826/#comment181506> s/evalutes/evaluates/g - Benjamin Bannier On Feb. 22, 2016, 8:50 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43826/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 8:50 a.m.) > > > Review request for mesos, Joerg Schad and Neil Conway. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > site/source/blog/2016-02-16-synchronized-statements-in-mesos.md > PRE-CREATION > > Diff: https://reviews.apache.org/r/43826/diff/ > > > Testing > ------- > > Locally rendered with `rake && rake dev` from `/site` > > > Thanks, > > Michael Park > >
