-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43826/#review120166
-----------------------------------------------------------




site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 15)
<https://reviews.apache.org/r/43826/#comment181565>

    "Java language feature" -- or in any case I'd probably drop the hyphen.



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 35)
<https://reviews.apache.org/r/43826/#comment181566>

    "class and"



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 42)
<https://reviews.apache.org/r/43826/#comment181579>

    I'm a little confused by the semantics of the proposed `if` statement -- 
you're saying the enclosing block only executes if `condition` is true? 
Syntactically it seems weird as well.
    
    How about
    
    ```
    {
      if_guard my_if(condition);
    
      // Block only executes if `condition` is true
    }
    ```



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 54)
<https://reviews.apache.org/r/43826/#comment181593>

    No comma



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 57)
<https://reviews.apache.org/r/43826/#comment181580>

    Remove the comma.



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 64)
<https://reviews.apache.org/r/43826/#comment181583>

    Seems a little unclear what you're referring to by "the patterns involving 
other RAII classes such as `std::vector`"



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 115)
<https://reviews.apache.org/r/43826/#comment181601>

    "scope and then destroyed"



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 121)
<https://reviews.apache.org/r/43826/#comment181602>

    Remove comma.



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 276)
<https://reviews.apache.org/r/43826/#comment181610>

    "If"



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 286)
<https://reviews.apache.org/r/43826/#comment181611>

    "Remembering all of these rules is simply too complicated, so we opt to use 
a more clever solution."



site/source/blog/2016-02-16-synchronized-statements-in-mesos.md (line 292)
<https://reviews.apache.org/r/43826/#comment181613>

    The usage "a control flow" is a bit unusual (at least to me). What about "a 
program fragment that is easier for the compiler to reason about"?


- Neil Conway


On Feb. 22, 2016, 7:50 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43826/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Joerg Schad and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   site/source/blog/2016-02-16-synchronized-statements-in-mesos.md 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43826/diff/
> 
> 
> Testing
> -------
> 
> Locally rendered with `rake && rake dev` from `/site`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to