> On Feb. 20, 2016, 8:19 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, lines 238-240 > > <https://reviews.apache.org/r/43776/diff/1/?file=1263492#file1263492line238> > > > > I think that we need to clarify that the `role` checking except "*" > > will be checked in `authorize`, the validation will not check roles except > > "*" now. > > > > Otherwise, someone might confused that why a framework with `roleA` can > > reserve resoures for `roleB`?
Actually, after looking at this test again, it is no longer necessary once the `role` parameter is removed from this validation function. With that parameter gone, this test does nothing at all :-) I updated the subsequent patch, https://reviews.apache.org/r/43777/, to remove this test. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/#review120028 ----------------------------------------------------------- On Feb. 22, 2016, 7:47 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43776/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 7:47 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway. > > > Bugs: MESOS-4591 > https://issues.apache.org/jira/browse/MESOS-4591 > > > Repository: mesos > > > Description > ------- > > Changed object of the `ReserveResources` ACL to `roles`. > > This solves a problem in which any principal could reserve resources for any > role using the '/reserve' operator endpoint. A new test, > `ReserveOperationValidationTest.DisallowReserveForStarRole`, was added. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto > 226441f8cbd6d0828bf1636cc08c21ffcc75e6a7 > src/authorizer/local/authorizer.cpp > 9557bbdf68ff182c4538bbf70cee576d717abc05 > src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 > src/master/validation.cpp 66898e914c7b4ab83c4580be67530f355cfb05ca > src/tests/authorization_tests.cpp 9d046e8d53cbb6c065a23ca3f7832021ec7faadc > src/tests/master_validation_tests.cpp > 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 > src/tests/reservation_endpoints_tests.cpp > afe81b1d38a1b3a82583720f26482ddcde8f5e85 > src/tests/reservation_tests.cpp d2ef15934556cb879f31850d52712aec77231fc7 > > Diff: https://reviews.apache.org/r/43776/diff/ > > > Testing > ------- > > Tests were altered to accomodate the new ACL object, and the test > `ReserveOperationValidationTest.DisallowReserveForStarRole` was added. > > Ran `configure && make check` and `configure --enable-libevent --enable-ssl > && make check` on OSX; all tests passed. > > > Thanks, > > Greg Mann > >
