-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43776/
-----------------------------------------------------------

(Updated Feb. 26, 2016, 4:53 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Neil Conway.


Changes
-------

Addressed comments.


Bugs: MESOS-4591
    https://issues.apache.org/jira/browse/MESOS-4591


Repository: mesos


Description
-------

Changed object of the `ReserveResources` ACL to `roles`.

This solves a problem in which any principal could reserve resources for any 
role using the '/reserve' operator endpoint. A new test, 
`ReserveOperationValidationTest.DisallowReserveForStarRole`, was added.


Diffs (updated)
-----

  include/mesos/authorizer/authorizer.proto 
226441f8cbd6d0828bf1636cc08c21ffcc75e6a7 
  src/authorizer/local/authorizer.cpp 9557bbdf68ff182c4538bbf70cee576d717abc05 
  src/master/master.cpp 8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 
  src/master/validation.cpp b0cc7f7ec75b66246686d1b50a61902f1455e8b6 
  src/tests/authorization_tests.cpp 9d046e8d53cbb6c065a23ca3f7832021ec7faadc 
  src/tests/master_validation_tests.cpp 
ab2df22f73052f6bd77653e56e7b460b17e7b0be 
  src/tests/reservation_endpoints_tests.cpp 
32b2af4115211b58a5127a14dd19152c2eca120c 
  src/tests/reservation_tests.cpp b8878d51767ac0d95e346c44c0a4d5c060e565ef 

Diff: https://reviews.apache.org/r/43776/diff/


Testing
-------

Tests were altered to accomodate the new ACL object, and the test 
`ReserveOperationValidationTest.DisallowReserveForStarRole` was added.

Ran `configure && make check` and `configure --enable-libevent --enable-ssl && 
make check` on OSX; all tests passed.


Thanks,

Greg Mann

Reply via email to