-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43855/#review120260
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 214)
<https://reviews.apache.org/r/43855/#comment181686>

    What about using `` to highlight move/rename?
    
    Same comments for others highlight.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 227)
<https://reviews.apache.org/r/43855/#comment181687>

    s/We expect/Expect
    
    Can you please add more comments for why only one directory is expected?



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 240)
<https://reviews.apache.org/r/43855/#comment181688>

    What about adding the image dir the log message for better trouble shooting?



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 281)
<https://reviews.apache.org/r/43855/#comment181689>

    What about using a uuid like dir here? There might be duplicate "XXXXXX" 
under /tmp



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 284)
<https://reviews.apache.org/r/43855/#comment181690>

    If a uuid like dir, then it is better add it to the log message when error 
happens



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 296)
<https://reviews.apache.org/r/43855/#comment181691>

    detailed failure here including both tmp and dest.



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 327)
<https://reviews.apache.org/r/43855/#comment181692>

    s/Fetches/Fetch



src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 346)
<https://reviews.apache.org/r/43855/#comment181684>

    alignment


- Guangya Liu


On 二月 22, 2016, 11:50 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43855/
> -----------------------------------------------------------
> 
> (Updated 二月 22, 2016, 11:50 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change allows store to fetch an image using Appc image fetcher when an
> image is not found in the cache. It also recursively fetches the dependencies
> for the image.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 4b3829175f57fb9aea2478040d96f2f127cbc551 
> 
> Diff: https://reviews.apache.org/r/43855/diff/
> 
> 
> Testing
> -------
> 
> make check; local image server.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to