> On 二月 23, 2016, 5:21 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 288
> > <https://reviews.apache.org/r/43855/diff/1/?file=1264857#file1264857line288>
> >
> >     What about using a uuid like dir here? There might be duplicate 
> > "XXXXXX" under /tmp

The docker provisioner is also using same logic, it is reasonable as this will 
be managed by mesos provisioner.


> On 二月 23, 2016, 5:21 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 291
> > <https://reviews.apache.org/r/43855/diff/1/?file=1264857#file1264857line291>
> >
> >     If a uuid like dir, then it is better add it to the log message when 
> > error happens

Does it make sense to put the temporary fetch directory in the error message 
for better trouble shooting?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43855/#review120260
-----------------------------------------------------------


On 二月 22, 2016, 11:50 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43855/
> -----------------------------------------------------------
> 
> (Updated 二月 22, 2016, 11:50 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change allows store to fetch an image using Appc image fetcher when an
> image is not found in the cache. It also recursively fetches the dependencies
> for the image.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> 4b3829175f57fb9aea2478040d96f2f127cbc551 
> 
> Diff: https://reviews.apache.org/r/43855/diff/
> 
> 
> Testing
> -------
> 
> make check; local image server.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to