----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120303 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/libevent_poll.cpp (line 56) <https://reviews.apache.org/r/43799/#comment181733> According to the style guide, we are usually using trailing underscores here. 3rdparty/libprocess/src/libevent_poll.cpp (line 57) <https://reviews.apache.org/r/43799/#comment181734> Although this should work as is, it is more straight forward and the common (generally safer) pattern to access the shared pointer here, not the weak one. _ev.get() (respectively ev_.get(), see above) - Bernd Mathiske On Feb. 19, 2016, 5:09 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43799/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 5:09 p.m.) > > > Review request for mesos, Joris Van Remoortere and Michael Park. > > > Bugs: MESOS-3271 and MESOS-4711 > https://issues.apache.org/jira/browse/MESOS-3271 > https://issues.apache.org/jira/browse/MESOS-4711 > > > Repository: mesos > > > Description > ------- > > Under certains circumstances, the future returned by poll is discarded right > after the event is triggered, this causes the event callback to be called > before the discard callback which results in an abort signal being raised > by the libevent library. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent_poll.cpp > 461624ca003e97be5ea9cf956d86fc294e6f1bc1 > > Diff: https://reviews.apache.org/r/43799/diff/ > > > Testing > ------- > > ```bash > # On CentOS 6.7 running in virtualbox > ../configure --enable-ssl --enable-libevent > make -j4 check > sudo ./bin/mesos-tests.sh > --gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" > --gtest_repeat=1000 > ``` > > > Thanks, > > Alexander Rojas > >
