-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43799/#review120932
-----------------------------------------------------------




3rdparty/libprocess/src/libevent_poll.cpp (line 50)
<https://reviews.apache.org/r/43799/#comment182470>

    Please add a very clear comment here that calls out the effect of this 
destructor invoking the event_free, which implies `event_del` which means the 
event will no longer be `pending`, and that's why we won't execute a 2nd time



3rdparty/libprocess/src/libevent_poll.cpp (lines 61 - 63)
<https://reviews.apache.org/r/43799/#comment182468>

    can you add a comment explaining why we are testing `event_pending`?
    Another comment for explaining that `event_active` triggers pollCallback to 
be run in the `event_loop`



3rdparty/libprocess/src/libevent_poll.cpp (lines 83 - 85)
<https://reviews.apache.org/r/43799/#comment182467>

    let's call out here that we're binding in the destructor, and the 
consequences of that.



3rdparty/libprocess/src/libevent_poll.cpp (lines 90 - 91)
<https://reviews.apache.org/r/43799/#comment182461>

    Please comment why we're using a weak_ptr here.



3rdparty/libprocess/src/libevent_poll.cpp (lines 91 - 93)
<https://reviews.apache.org/r/43799/#comment182462>

    Please comment that this is the explicit order we want these 2 statements 
in.


- Joris Van Remoortere


On Feb. 24, 2016, 9:30 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43799/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 9:30 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Bugs: MESOS-3271 and MESOS-4711
>     https://issues.apache.org/jira/browse/MESOS-3271
>     https://issues.apache.org/jira/browse/MESOS-4711
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Under certains circumstances, the future returned by poll is discarded right
> after the event is triggered, this causes the event callback to be called
> before the discard callback which results in an abort signal being raised
> by the libevent library.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent_poll.cpp 
> 461624ca003e97be5ea9cf956d86fc294e6f1bc1 
> 
> Diff: https://reviews.apache.org/r/43799/diff/
> 
> 
> Testing
> -------
> 
> ```bash
> # On CentOS 6.7 running in virtualbox
> ../configure --enable-ssl --enable-libevent
> make -j4 check
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
> --gtest_repeat=1000
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to