> On Feb. 23, 2016, 12:45 p.m., Klaus Ma wrote:
> > src/master/master.hpp, line 545
> > <https://reviews.apache.org/r/43868/diff/1/?file=1264993#file1264993line545>
> >
> >     `getFlags() const`
> 
> Jay Guo wrote:
>     OK

We found that *constant member funtion* here requires a new `dispatch()` 
template:
```cpp
template <typename R, typename T>
Future<R> dispatch(const PID<T>& pid, R (T::*method)() const)
```

original:
```cpp
template <typename R, typename T>
Future<R> dispatch(const PID<T>& pid, R (T::*method)())
```

notice *const* following `R (T::*method)()` in arguments.

Otherwise compiler complains. Should we add it?


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43868/#review120300
-----------------------------------------------------------


On Feb. 23, 2016, 5:23 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43868/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 5:23 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Joris Van Remoortere, and Qian Zhang.
> 
> 
> Bugs: MESOS-3481
>     https://issues.apache.org/jira/browse/MESOS-3481
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3481 Add const accessor to Master flags.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
>   src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf 
> 
> Diff: https://reviews.apache.org/r/43868/diff/
> 
> 
> Testing
> -------
> 
> Added one new unit test MasterTest::Flags
> 
> `make check` passed
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Reply via email to