> On Feb. 24, 2016, 9:44 a.m., Qian Zhang wrote: > > With this patch, do we still need to explicitly call `CreateMasterFlags()` > > in the test cases (e.g., > > https://github.com/apache/mesos/blob/2876b8c918814347dd56f6f87d461e414a90650a/src/tests/master_maintenance_tests.cpp#L1231-L1235)? > > I see `CreateMasterFlags()` will be internally called by `StartMaster()`, > > so for all the test cases which calls `CreateMasterFlags()` first and then > > `StartMaster()`, should we change them to call `StartMaster()` and then > > `getFlags()` that you added in this patch? > > Jay Guo wrote: > Yes we believe this is exactly the intention of adding getter method. And > we have actually experimented modifying original test to use `StartMaster()` > and `getFlags()`. **However**, there are approx 50 instances in current code > base using `StartMaster(flags)`. We fear *changing all of them is beyond the > scope of this task*. Thoughts?
Yes, maybe we need to upload a separate commit or create a separate JIRA ticket for it. Since Joris is the shepherd of this ticket, I'd like to leave this to him :-) - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43868/#review120432 ----------------------------------------------------------- On Feb. 24, 2016, 11:42 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43868/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 11:42 a.m.) > > > Review request for mesos, Guangya Liu, Joris Van Remoortere, and Qian Zhang. > > > Bugs: MESOS-3481 > https://issues.apache.org/jira/browse/MESOS-3481 > > > Repository: mesos > > > Description > ------- > > MESOS-3481 Add const accessor to Master flags. > > > Diffs > ----- > > src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d > src/tests/master_tests.cpp 0bd8c0e42f335cad7ed858c6af5aa4f07bb37dbf > > Diff: https://reviews.apache.org/r/43868/diff/ > > > Testing > ------- > > Added one new unit test MasterTest::Flags > > `make check` passed > > > Thanks, > > Jay Guo > >
