----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43410/#review120611 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/posix/dynamiclibrary.hpp (lines 50 - 52) <https://reviews.apache.org/r/43410/#comment182079> Not yours, but fits in one line. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp (lines 50 - 51) <https://reviews.apache.org/r/43410/#comment182077> Fits in one line. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp (line 65) <https://reviews.apache.org/r/43410/#comment182076> This C-style cast to `HMODULE` seems to indicate that `handle_` should be of type `HMODULE`. In fact `LoadLibrary`'s return type is `HMODULE`, so it seems to line up well? 3rdparty/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp (lines 67 - 68) <https://reviews.apache.org/r/43410/#comment182078> Fits in one line. - Michael Park On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43410/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 12:59 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4496 > https://issues.apache.org/jira/browse/MESOS-4496 > > > Repository: mesos > > > Description > ------- > > Originally review #40583, this was resurrected when Dario went on > paternity leave. Minor changes were made, the review itself remains > largely in tact. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp > 166c97d3e4b07451b8b4c01092cecb69315c691a > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/dynamiclibrary.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/43410/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
