----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review120710 -----------------------------------------------------------
include/mesos/mesos.proto (line 1576) <https://reviews.apache.org/r/44004/#comment182168> Should we be more elaborate in our description? Maybe: This will be used by the container run-time to determine the network that this container joins. For e.g., for `MesosContainerizer` this would represent the CNI network to which the container will be attached. include/mesos/v1/mesos.proto (line 1573) <https://reviews.apache.org/r/44004/#comment182169> Ditto. - Avinash sridharan On Feb. 25, 2016, 3:15 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44004/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 3:15 p.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-4758 > https://issues.apache.org/jira/browse/MESOS-4758 > > > Repository: mesos > > > Description > ------- > > Add 'name' field into NetworkInfo. > > > Diffs > ----- > > include/mesos/mesos.proto 33f6b0838360b61db70a247e5d6dfb16af15aa06 > include/mesos/v1/mesos.proto 1b0e709e76f3f6b44ab0434c649c064e8866c8a1 > > Diff: https://reviews.apache.org/r/44004/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
