> On Feb. 26, 2016, 9 a.m., Avinash sridharan wrote: > > include/mesos/mesos.proto, line 1577 > > <https://reviews.apache.org/r/44004/diff/1/?file=1270994#file1270994line1577> > > > > In order to expose this field in state.json, I think you need to add > > the filed to the corresponding `model` function in src/common/http.cpp as > > well. > > > > We won't need this once we move to the new JSONIFY api, but I think we > > would need it in the immediate future.
Agree. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review120810 ----------------------------------------------------------- On Feb. 26, 2016, 10:01 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44004/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 10:01 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4758 > https://issues.apache.org/jira/browse/MESOS-4758 > > > Repository: mesos > > > Description > ------- > > Add 'name' field into NetworkInfo. > > > Diffs > ----- > > include/mesos/mesos.proto 33f6b0838360b61db70a247e5d6dfb16af15aa06 > include/mesos/v1/mesos.proto 1b0e709e76f3f6b44ab0434c649c064e8866c8a1 > > Diff: https://reviews.apache.org/r/44004/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
