-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44026/#review120813
-----------------------------------------------------------


Fix it, then Ship it!




LGTM, Just one minor query around moving one more additional test.

Thanks for resolving this tech debt.


3rdparty/libprocess/src/tests/process_tests.cpp (lines 1300 - 1312)
<https://reviews.apache.org/r/44026/#comment182314>

    Should this be moved to `future_tests.cpp` too?


- Anand Mazumdar


On Feb. 25, 2016, 5:59 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44026/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 5:59 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved future tests into future_tests.cpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/future_tests.cpp 
> ded1aaed25876d45e33b4a27fffc6a5c46ca92f5 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> e9bf80ee69f4add299cb828ed3245ac07398943c 
> 
> Diff: https://reviews.apache.org/r/44026/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Reply via email to