-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/#review121224
-----------------------------------------------------------




src/tests/state_tests.cpp (line 404)
<https://reviews.apache.org/r/44163/#comment182912>

    IMHO this comment is unnecessary.



src/tests/state_tests.cpp (line 409)
<https://reviews.apache.org/r/44163/#comment182908>

    This is no longer needed, because `TemporaryDirectoryTest::TearDown` will 
remove the sandbox directory.



src/tests/state_tests.cpp (line 416)
<https://reviews.apache.org/r/44163/#comment182910>

    Make this the last statement of the function, because `storage` and `state` 
rely on directories that will be deleted by this function.



src/tests/state_tests.cpp (line 420)
<https://reviews.apache.org/r/44163/#comment182909>

    Same as above.


- Jan Schlicht


On Feb. 29, 2016, 11:53 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44163/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 11:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4806
>     https://issues.apache.org/jira/browse/MESOS-4806
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used temporary directory for fixture creating output files.
> 
> 
> Diffs
> -----
> 
>   src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 
> 
> Diff: https://reviews.apache.org/r/44163/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, not optimized)
> 
> * before this patch running the test from a non-writable directory fails; 
> with this patch the test passes,
> * before this patch running gtest-parallel with filter `LevelDBState*` fails; 
> with the patch the test passes.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to