-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/#review121484
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 125 - 129)
<https://reviews.apache.org/r/43914/#comment183199>

    Can you use a nested for loop here? We might want to support non-contiguous 
secondaries in the future, let's write some code that's future proof.



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 166 - 169)
<https://reviews.apache.org/r/43914/#comment183200>

    Ditto on using a nested for loop


- Jie Yu


On March 1, 2016, 7:58 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43914/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 7:58 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4700
>     https://issues.apache.org/jira/browse/MESOS-4700
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
> now work with a specified range of secondary handles instead of
> assuming that the entire 64K space of secondary handles is available
> for use.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 
> acd61e615951e18dd51a2ce1e746ba733e9159ae 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 
> f05cd55a9e080f44566ec7dcef22f11950496d6f 
> 
> Diff: https://reviews.apache.org/r/43914/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> Also ran sudo make check for the "NetClsIsolatoTest"
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to