----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44232/#review121527 -----------------------------------------------------------
Ship it! In some random location: ``` mkdir evil sudo mount --bind evil /tmp ``` Then applied this patch and ran: ``` GLOG_v=1 sudo -E bin/mesos-tests.sh --gtest_filter="*RecoverOrphanedPersistentVolumes" --verbose sudo umount /tmp GLOG_v=1 sudo -E bin/mesos-tests.sh --gtest_filter="*RecoverOrphanedPersistentVolumes" --verbose ``` src/slave/containerizer/docker.cpp (lines 585 - 586) <https://reviews.apache.org/r/44232/#comment183284> It would be a slightly stronger check if you include this as well: ``` strings::startsWith(entry.root, volumesRootDir) ``` I added `paths::getVolumeRootDir` here: https://reviews.apache.org/r/44196/ - Joseph Wu On March 1, 2016, 3:50 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44232/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 3:50 p.m.) > > > Review request for mesos, Joseph Wu and Timothy Chen. > > > Bugs: MESOS-4832 > https://issues.apache.org/jira/browse/MESOS-4832 > > > Repository: mesos > > > Description > ------- > > Added a check when umounting persistent volumes in docker containerizer. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b > src/slave/containerizer/docker.cpp 0ed271b329d4cb862c4fd28ce2069ef41be637cc > > Diff: https://reviews.apache.org/r/44232/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
