> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2406 > > <https://reviews.apache.org/r/43880/diff/9/?file=1273636#file1273636line2406> > > > > I believe the actual value in JSON is double, right?
This is actually a `JSON::Value`; the corresponding `operator==` which will convert the lhs to a `JSON::Value` as well. > On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 402 > > <https://reviews.apache.org/r/43880/diff/9/?file=1273635#file1273635line402> > > > > Can we factor this out to a separate file? I would like to keep this > > file as small and readable as possible. I moved this into the `Metrics` (which also live in a different file now). > On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2445-2446 > > <https://reviews.apache.org/r/43880/diff/9/?file=1273636#file1273636line2445> > > > > How it is different to the previous block? Thanks, my `Control-C Control-V` key must have been stuck ;) > On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2476 > > <https://reviews.apache.org/r/43880/diff/9/?file=1273636#file1273636line2476> > > > > Why this math? I added some comments. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review121405 ----------------------------------------------------------- On March 2, 2016, 11:35 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43880/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 11:35 a.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4720 > https://issues.apache.org/jira/browse/MESOS-4720 > > > Repository: mesos > > > Description > ------- > > Added allocator metrics for total and allocated scalar resources. > > > Diffs > ----- > > docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 24fa50f62dec10ed43089297473cc386d6ba2f78 > src/master/allocator/mesos/metrics.hpp PRE-CREATION > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43880/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
