> On March 3, 2016, 2:26 p.m., Joseph Wu wrote: > > include/mesos/master/contender.hpp, line 43 > > <https://reviews.apache.org/r/44287/diff/3/?file=1279697#file1279697line43> > > > > I'm going to reiterate this comment > > (https://reviews.apache.org/r/43269/#comment181059). > > > > For modules, the "type" is some string that identifies the entry point > > of the entry. To be backwards compatible and support modules, you will > > need either 2 arguments or 2 separate factory methods (or some really ugly > > logic inside the factory method). > > Anurag Singh wrote: > The type is expected to come from the master_contender and > master_detector flags from change https://reviews.apache.org/r/44288. So type > would be the module name (as you had suggested in > https://reviews.apache.org/r/43269/). The parameters (from the JSON set in > --modules) are passed to the module by ModuleManager::create. As far as > backwards compatibility is concerned, the --zk flag will continue to work as > it does now. Can you explain the need for 2 separate arguments?
This is necessary for the detector (https://reviews.apache.org/r/44289/diff/3#7.30 ). There's no guarantee that a module "type" is not parsable as a `UPID`. (And if we can make this separation explicit in the code, we should.) - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review121946 ----------------------------------------------------------- On March 3, 2016, 9:29 a.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44287/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 9:29 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > MasterContender and MasterDetector abstract classes can be subclassed by > user-provided classes to allow for arbitrary contender/detector > implementations. > > > Diffs > ----- > > include/mesos/master/contender.hpp PRE-CREATION > include/mesos/master/detector.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44287/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/44289/. > > > Thanks, > > Anurag Singh > >
