----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review122011 -----------------------------------------------------------
src/slave/containerizer/docker.cpp (lines 136 - 137) <https://reviews.apache.org/r/39939/#comment183864> I should mention this early, it was always good to add some detail info to the error messages or logs. What about update the message as: return Error("The current docker socket '" + flags.docker_socket + "' is not valid," " only unix domain socket is supported for `docker_socket` when" " `docker_mesos_image` is enabled"); - Guangya Liu On 三月 4, 2016, 3:41 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39939/ > ----------------------------------------------------------- > > (Updated 三月 4, 2016, 3:41 a.m.) > > > Review request for mesos, Klaus Ma and Timothy Chen. > > > Bugs: MESOS-3821 > https://issues.apache.org/jira/browse/MESOS-3821 > > > Repository: mesos > > > Description > ------- > > Make docker_socket option support different protocols. > > > Diffs > ----- > > docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c > docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac > src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 > src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 > src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 > src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 > > Diff: https://reviews.apache.org/r/39939/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >