-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44334/#review122058
-----------------------------------------------------------
"{}" is short, but cryptic. It is unclear what kind of entity is being passed
here. "EMPTY" was not any better. "hashmap<SlaveID, Resources>()" at least
revealed the type which hinted a little at the presumable purpose. A better
identifier than "EMPTY" would beat all of the above. Maybe "NO_USED_RESOURCES"?
Could the parameter of the methods in question be supplied with a default
value? Then no corresponding argument at all would appear in these tests.
- Bernd Mathiske
On March 3, 2016, 5 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44334/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 5 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp
> 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1
>
> Diff: https://reviews.apache.org/r/44334/diff/
>
>
> Testing
> -------
>
> Tested as a chain in https://reviews.apache.org/r/44336/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
