-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44258/
-----------------------------------------------------------
(Updated March 5, 2016, 12:34 a.m.)
Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-4831
https://issues.apache.org/jira/browse/MESOS-4831
Repository: mesos
Description
-------
There is a bug when setting host maintain with http endpoint:
https://github.com/apache/mesos/blob/master/src/master/http.cpp#L1987-L2021
The logic is as this:
1) Get all host list from maintain window and put it to updated hashmap.
2) If the machine in was in updated was also in master->machines, call master
updateUnavailability to trigger recoverResources, updateUnavailability etc in
allocator
3) Otherwise, clear the unavailabity time window for the machine.
4) Update each new machines in updated to call master updateUnavailability
But the logic in step 4) is getting all machines from the schedule windows but
not the machines that is new to the cluster, this caused master get two
updateUnavailability calls for a machine in the updated hashmap.
The fix is filter machines in updated hashmap when handling new machines.
Diffs (updated)
-----
src/master/http.cpp 8276baa538eb4d2aaf54cc1aa516bffaadacc4dd
src/tests/master_maintenance_tests.cpp
3faa8136cf57276295553910319480028f433e4c
Diff: https://reviews.apache.org/r/44258/diff/
Testing
-------
make
make check
./bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.*" --verbose
Thanks,
Guangya Liu
