----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122280 -----------------------------------------------------------
Fix it, then Ship it! src/tests/hierarchical_allocator_tests.cpp (lines 2444 - 2446) <https://reviews.apache.org/r/43824/#comment184212> Nice! We use and treat `{}` blocks as subtests, hence they need a leading comment explaining what is going to happen (what is being tested), similar to tests themselves. src/tests/hierarchical_allocator_tests.cpp (line 2456) <https://reviews.apache.org/r/43824/#comment184211> Please move "ensure" onto the previous line. src/tests/hierarchical_allocator_tests.cpp (lines 2492 - 2494) <https://reviews.apache.org/r/43824/#comment184213> See my comment above. src/tests/hierarchical_allocator_tests.cpp (lines 2545 - 2547) <https://reviews.apache.org/r/43824/#comment184214> Ditto. - Alexander Rukletsov On March 3, 2016, 2:05 p.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43824/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 2:05 p.m.) > > > Review request for mesos, Adam B and Alexander Rukletsov. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > ------- > > Addressed comments of 41672. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 > > Diff: https://reviews.apache.org/r/43824/diff/ > > > Testing > ------- > > make && make check successfully. > > > Thanks, > > Yongqiao Wang > >
