> On March 3, 2016, 1:03 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2607-2609
> > <https://reviews.apache.org/r/43824/diff/2/?file=1275001#file1275001line2607>
> >
> >     I'm an ESL, but having both "per weight" and "by weight" sounds a bit 
> > strange. Maybe Adam can help wiht finding the right preposition.
> 
> Yongqiao Wang wrote:
>     Thanks Alex. @Adam, I am also an ESL. What is your suggestion for this?

s/per role's weight/according to each role's weight/
s/number of resources by their role's weight/appropriate number of resources/


> On March 3, 2016, 1:03 a.m., Alexander Rukletsov wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 2652-2654
> > <https://reviews.apache.org/r/43824/diff/2/?file=1275001#file1275001line2652>
> >
> >     How about
> >     
> >     // Framework2 registers with 'role2' which also uses the default 
> > weight. It
> >     // will not get any offers because all resources are offered to 
> > `framework1`.
> 
> Yongqiao Wang wrote:
>     I remember I wrote this comment like you before. The current comment is 
> changed with Adam's comments. @Adam, any further comments for this?

I'm fine with either, but Alex's is shorter.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43824/#review121642
-----------------------------------------------------------


On March 7, 2016, 5:55 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43824/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 5:55 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4200
>     https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Addressed comments of 41672.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 
> 
> Diff: https://reviews.apache.org/r/43824/diff/
> 
> 
> Testing
> -------
> 
> make && make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Reply via email to