> On March 5, 2016, 3:18 a.m., Guangya Liu wrote: > > docs/container-image.md, line 11 > > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line11> > > > > s/containerizers/__containerizers__
I think this is fine? Why do you want to make it bold? > On March 5, 2016, 3:18 a.m., Guangya Liu wrote: > > docs/container-image.md, lines 44-46 > > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line44> > > > > What about highlight Docker, AppC, OCF here? > > s/Docker/__Docker__ > > s/AppC/__AppC__ > > s/OCF/__OCF__ Ditto. I think this is fine to me. > On March 5, 2016, 3:18 a.m., Guangya Liu wrote: > > docs/container-image.md, lines 67-77 > > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line67> > > > > Does it make sense to enable slave add those isolations based on > > containizer technology? If using `Docker`, then add `docker/runtime` > > dynamically if the `isolation` flag does not include `docker/runtime`? This > > can make the configuration simple. I think that's a good idea. We need to do that for filesystem/linux as well. Let's address that in a separate ticket. Here, I just want to document the existing behavior. > On March 5, 2016, 3:18 a.m., Guangya Liu wrote: > > docs/container-image.md, lines 124-130 > > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line124> > > > > Does it make sense to guide end user/framework developer refer to > > https://github.com/apache/mesos/blob/master/src/cli/execute.cpp for an > > example? I see that there are someone asking this question in dev list, it > > would be great if we can add the reference code here. The CLI is too generic. I think we should have an example framework. I'll create a ticket. > On March 5, 2016, 3:18 a.m., Guangya Liu wrote: > > docs/container-image.md, line 152 > > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line152> > > > > s/start the Mesos agent/start the Mesos agent with docker as image > > provider It's pretty obvious in the following command that we are allowing docker images. > On March 5, 2016, 3:18 a.m., Guangya Liu wrote: > > docs/container-image.md, line 283 > > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line283> > > > > I uploaded a patch here: https://reviews.apache.org/r/44391/ > > > > Will rebase this patch as mesos-provisioner.md is now deleted. Yeah, I'll merge that later. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44414/#review122175 ----------------------------------------------------------- On March 5, 2016, 2:20 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44414/ > ----------------------------------------------------------- > > (Updated March 5, 2016, 2:20 a.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, Neil Conway, Timothy > Chen, and Vinod Kone. > > > Bugs: MESOS-4873 > https://issues.apache.org/jira/browse/MESOS-4873 > > > Repository: mesos > > > Description > ------- > > Added documentation about container image support. > > > Diffs > ----- > > docs/container-image.md PRE-CREATION > docs/mesos-provisioner.md 1b19406cb93bbc3f5330eaf9d29b1be98a674136 > > Diff: https://reviews.apache.org/r/44414/diff/ > > > Testing > ------- > > Tested the formatting in Mou > > > Thanks, > > Jie Yu > >
