> On March 7, 2016, 6:40 p.m., Gilbert Song wrote:
> > docs/container-image.md, lines 54-60
> > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line54>
> >
> >     Should we explain why do we allow multiple types? because users may ask 
> > `why don't I specify all possible image providers if I want to use unified 
> > containerizer`.

I don't follow. I think the reason we need this flag is to allow operators to 
control if they want to allow this feature or not.


> On March 7, 2016, 6:40 p.m., Gilbert Song wrote:
> > docs/container-image.md, line 64
> > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line64>
> >
> >     s/needs/may need/g
> >     
> >     to make distinction between appc runtime vs docker runtime in the 
> > future.

I think I already mentioned that?


> On March 7, 2016, 6:40 p.m., Gilbert Song wrote:
> > docs/container-image.md, lines 82-85
> > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line82>
> >
> >     Should we add `--launcher=linux`?

I think we'll use linux launcher by default on linux. I don't want to confuse 
readers.


> On March 7, 2016, 6:40 p.m., Gilbert Song wrote:
> > docs/container-image.md, line 150
> > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line150>
> >
> >     sbin -> /bin

It's sbin after make install.


> On March 7, 2016, 6:40 p.m., Gilbert Song wrote:
> > docs/container-image.md, line 185
> > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line185>
> >
> >     should we memtion `~/.curlrc`?

Nope.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44414/#review122308
-----------------------------------------------------------


On March 5, 2016, 2:20 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44414/
> -----------------------------------------------------------
> 
> (Updated March 5, 2016, 2:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, Neil Conway, Timothy 
> Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-4873
>     https://issues.apache.org/jira/browse/MESOS-4873
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation about container image support.
> 
> 
> Diffs
> -----
> 
>   docs/container-image.md PRE-CREATION 
>   docs/mesos-provisioner.md 1b19406cb93bbc3f5330eaf9d29b1be98a674136 
> 
> Diff: https://reviews.apache.org/r/44414/diff/
> 
> 
> Testing
> -------
> 
> Tested the formatting in Mou
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to