-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43863/#review122493
-----------------------------------------------------------


Fix it, then Ship it!





src/master/weights.hpp (line 35)
<https://reviews.apache.org/r/43863/#comment184522>

    Kill the blank line



src/master/weights.hpp (line 60)
<https://reviews.apache.org/r/43863/#comment184524>

    I like that you omit names for unused parameters, but please keep those, 
which are used (`registry`)! This serves as documentation.



src/master/weights.cpp (lines 51 - 52)
<https://reviews.apache.org/r/43863/#comment184526>

    Blank line, please.


- Alexander Rukletsov


On Feb. 27, 2016, 12:43 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43863/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 12:43 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4214
>     https://issues.apache.org/jira/browse/MESOS-4214
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move the implementation of updateWeights out of header.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 49a5645ef7242dbaee31e7b26dbbcb1f4f1f910e 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
>   src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 
>   src/master/weights.hpp PRE-CREATION 
>   src/master/weights.cpp PRE-CREATION 
>   src/master/weights_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43863/diff/
> 
> 
> Testing
> -------
> 
> make && make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Reply via email to