-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44361/#review122582
-----------------------------------------------------------


Fix it, then Ship it!




Looks good, thanks!


configure.ac (lines 215 - 216)
<https://reviews.apache.org/r/44361/#comment184697>

    Could you do a sweep and capitalize NVML, Nvidia, and GPU in the comments? 
The convention is to do acronyms in all caps, but we unfortunately do this for 
classes as well, like URL, which we should change at some point since it leads 
to confusing name boundaries (e.g. HTTPConnection would be better named as 
HttpConnection, this doesn't exist but it's just an example. Another example is 
http:: vs JSON::, ideally namespace names are only lower case).



configure.ac (lines 957 - 976)
<https://reviews.apache.org/r/44361/#comment184698>

    Could we flatten this to make it a bit easier to read?


- Ben Mahler


On March 4, 2016, 1:09 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44361/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 1:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Rob Todd.
> 
> 
> Bugs: MESOS-4861
>     https://issues.apache.org/jira/browse/MESOS-4861
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is the initial commit to begin adding native support for GPUs in
> Mesos. This initial version will only include support for Nvidia GPUs
> that can be managed by the Nvidia Management Library (nvml).
> 
> The configure flags added in this commit can be used to enable Nvidia
> GPU support, as well as specify the installation directories of the
> nvml header and library files if not already installed in standard
> include/library paths on the system.
> 
> In a subsequent commit, we will use these configure flags to
> conditionally build support for Nvidia GPUs into Mesos.
> 
> 
> Diffs
> -----
> 
>   configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517 
> 
> Diff: https://reviews.apache.org/r/44361/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to