----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44363/#review122633 -----------------------------------------------------------
Ship it! Ship It! - Vikrama Ditya On March 8, 2016, 10:46 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44363/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 10:46 p.m.) > > > Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. > > > Bugs: MESOS-4623 > https://issues.apache.org/jira/browse/MESOS-4623 > > > Repository: mesos > > > Description > ------- > > This is the first isolator to fall under the category of cgroup > devices. However, we do not yet have a generic cgroup device isolator > (nor will we in the very near future). As such, I have preemptively > created the nvidia gpu isolator in the directory hierarchy under the > path: > > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/ > > in order to easily allow them to fall under the category of gpu > devices later on. > > In this stub implementation, initialization of the agent will > fail if the nvidia gpu isolator is enabled via the agent --isolation > flag. That is --isolation="cgroups/devices/gpu/nvidia". In a > subsequent commit we will fill in the guts to actually enable the > proper isolation. > > The flags documentation has been udpated accordingly. > > > Diffs > ----- > > docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c > src/Makefile.am 5b54fe04734afc5faa1bba3b84f43a1b8efe8753 > src/slave/containerizer/mesos/containerizer.cpp > af3ff5750649497d8852b4761c78d4cae5455a02 > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp > PRE-CREATION > src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 > > Diff: https://reviews.apache.org/r/44363/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
